Sorting discussions by votes

tmilovan

It would be really great if we could sort discussions on "Popular" dicussion list by votes. Or is this already possible somehow?

Raize

kind of like digg

helmi

that'll sound good. having such a sort option would be great.

Linc

Doesn't clicking on the "Votes" tab before the first comment accomplish this?

tmilovan

No, or yes ) but only for comments. I was thinking about sorting discussions on discussions list.

scoobeee

I just realized the "popular" tab in the discussions page does not take into account votes like I thought. Kind of makes voting on discussions a bit futile right? Has anyone implemented a sort on votes tab for discussions not comments?

jamesmcintyre

I second @scoobee, shouldn't there be an option to sort discussions by vote and make this the default view?

realrasengan

Find:

DiscussionModel->SQL->OrderBy('d.CountViews', 'desc');
(for me it was line 458)

Comment out and insert:
$DiscussionModel->SQL->OrderBy('COALESCE(d.Score,0)', 'desc');

Now you will have it sorted by vote.

charliepratt

Thanks, @realrasengan. That worked like a charm.

charliepratt

Followup: is there a way to constrain the date range for this view of popular discussions? I'd like to avoid having a static list of "all-time" popular discussions, and opt instead for a 30-day range.

hgtonight

@charliepratt add a where statement that compares DateUpdated to 30 days ago. Something like:

$DiscussionModel->SQL->OrderBy('COALESCE(d.Score,0)', 'desc')
  ->Where('DateUpdated >=', 'NOW() - INTERVAL 1 MONTH');

charliepratt

@hgtonight just tried this option and it returns no results.

hgtonight

You probably have to add a d. in front of the field.

    $DiscussionModel->SQL->OrderBy('COALESCE(d.Score,0)', 'desc')
    ->Where('d.DateUpdated >=', 'NOW() - INTERVAL 1 MONTH');

I can't test against Vanilla right now.

peregrine

try this:

->Where('d.DateUpdated >=', Gdn_Format::ToDateTime(strtotime('-30 days')));

but be forewarned your pager will still show additional pages where discussion topics will be blank because of the where restriction, but it will do the job.

Todd presented this tip for me months ago for a different table.

I suspect you could change the pager to reflect the proper count based on number of discussions retrieved, but that I'll leave up to you to research .

peregrine

or this

 $DiscussionModel->SQL->OrderBy('COALESCE(d.Score,0)', 'desc')
       ->Where('d.DateLastComment >=', Gdn_Format::ToDateTime(strtotime('-30 days')))
       ->OrWhere('d.DateUpdated >=', Gdn_Format::ToDateTime(strtotime('-30 days')));

depending on what you want to do based on what.

for a 30-day range of what?

30 days since last comment maybe better.

charliepratt

@peregrine said:

try this:

->Where('d.DateUpdated >=', Gdn_Format::ToDateTime(strtotime('-30 days')));

@peregrine - this did what I needed. Thanks to @hgtonight for the alley oop.

dominikl

I am sorry but can you tell me in which file I have to edit? You all seem to know which file you are talking about, but i don´t =D

hgtonight

@dominikl Pretty sure this is fixed in the latest version of the Voting addon: https://github.com/vanilla/addons/blob/301a22488311806e0763e1f855473f04c3e06623/plugins/Voting/class.voting.plugin.php#L149