Please upgrade here. These earlier versions are no longer being updated and have security issues.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.
Options

[GitHub Bug #1651] @user doesn't always work

2»

Comments

  • Options

    @Lincoln said:
    Not supporting spaces or encapsulation isn't a bug tho, that's a feature request.

    I didn't say it was.

    grep is your friend.

  • Options
    R_JR_J Ex-Fanboy Munich Admin

    I made two pull requests and linked them to UnderDoggs bug ticket. Hope they help you.

    Btw: I was impressed by that comment of yours. It was motivating for me. Creating addons is one way of promoting Vanilla but the other one is solving issues. Call me naive, but I haven't realized that before.

  • Options
    hgtonighthgtonight ∞ · New Moderator

    @x00 said:
    It would make sense encapsulate mentions

    The way I understand it is that users can only have spaces in their names if they are imported. This means it is an issue on their end.

    If you do support encapsulation, it would make more sense to just use @ symbols. E.g. @Monkey Wrench@.

    Search first

    Check out the Documentation! We are always looking for new content and pull requests.

    Click on insightful, awesome, and funny reactions to thank community volunteers for their valuable posts.

  • Options
    hgtonighthgtonight ∞ · New Moderator

    @Lincoln said:
    Not supporting spaces or encapsulation isn't a bug tho, that's a feature request.

    I would say not supporting valid usernames is a bug. Not sure where the feature list for @mentions is though ;)

    Search first

    Check out the Documentation! We are always looking for new content and pull requests.

    Click on insightful, awesome, and funny reactions to thank community volunteers for their valuable posts.

  • Options

    @hgtonight said:
    If you do support encapsulation, it would make more sense to just use @ symbols. E.g. @Monkey Wrench@.

    Um not sure I agree. I think the @user format is more elegant an easier to parse, both encapsulated or not.

    think about it

    @userneme some@email.com
    

    grep is your friend.

  • Options
    hgtonighthgtonight ∞ · New Moderator

    @x00 said:
    I think the @user format is more elegant an easier to parse

    I agree it would be easier to parse. Just talking from a UX perspective, it would make sense to use the same symbol to open and close.

    In my world, make it support escaped spaces and you are good to go.

    Search first

    Check out the Documentation! We are always looking for new content and pull requests.

    Click on insightful, awesome, and funny reactions to thank community volunteers for their valuable posts.

  • Options

    well often + is a good substitute for space.

    grep is your friend.

  • Options
    hgtonighthgtonight ∞ · New Moderator

    @x00 said:
    well often + is a good substitute for space.

    I like this. Or use a _.

    When I ported my community over from an old phpbb install, I forced users with spaces to pick a new username. I offered them a few variations of replacing the spaces with other symbols (_-.). They invariably chose the underscore or removing the space all together and camel casing the transition.

    Search first

    Check out the Documentation! We are always looking for new content and pull requests.

    Click on insightful, awesome, and funny reactions to thank community volunteers for their valuable posts.

  • Options
    LincLinc Detroit Admin

    My solution was to simply strip all non-alphanumeric characters in usernames after importing. It worked surprisingly well and with little confusion.

  • Options
    R_JR_J Ex-Fanboy Munich Admin

    When you allow spaces in your forum, don't forget to disallow ALT+255 => " " and spaces at the end of a username. They can be misused to fool forum users (did it myself when I was young and wild)

Sign In or Register to comment.