Memory Allocation Error

vrijvlinder

Hi I was testing this plugin and am getting memory allocation error on line 388 of the geoip.inc file of the World Flags Plugin. using Vanilla 2.0.18.4

$gi->memory_buffer = fread($gi->filehandle, $s_array['size']);

vrijvlinder

I suspect something here needs fixing,

function geoip_open($filename, $flags) {
  $gi = new GeoIP;
  $gi->flags = $flags;
  if ($gi->flags & GEOIP_SHARED_MEMORY) {
    $gi->shmid = @shmop_open (GEOIP_SHM_KEY, "a", 0, 0);
    } else {
    $gi->filehandle = fopen($filename,"rb") or die( "Can not open $filename\n" );
    if ($gi->flags & GEOIP_MEMORY_CACHE) {
        $s_array = fstat($gi->filehandle);
        $gi->memory_buffer = fread($gi->filehandle, $s_array['size']);
    }
  }

  $gi = _setup_segments($gi);
  return $gi;
}

function geoip_close($gi) {
  if ($gi->flags & GEOIP_SHARED_MEMORY) {
    return true;
  }

  return fclose($gi->filehandle);
}

vrijvlinder

I am not sure what to look at here , I would like to make this plugin work without errors, does anyone use this plugin ?

hgtonight

I tested it on a clean 2.0.18.4 local install. It worked well.

The data file this thing loads is 17mb though. I am guessing that just put you over your php memory limit.

Sorry I have no better solution.

vrijvlinder

yea the dat file is heavy , No I think the issue is with some kind of a loop that formed. I have plenty of memory. What I suspect is that when I download the dat gets messed up because it is not a mac compatible type file.

peregrine

I haven't tried this, but there is another flag-related plugin

http://vanillaforums.org/addon/geoipflags-plugin

vrijvlinder

yea the only difference is that one puts a flag also on the user profile and this one does not. Something that could be added I suppose. Seems they both use the geoip .
I will test this one...

When I installed the first it messed up the user page in the dashboard , no style no user columns. Tried editing this and that but no success yet.

vrijvlinder

I opened the dat file with sublime text editor to see the contents and there is not much in there except what I think are longitude and latitude IP combinations .

It is only a list....I think maybe GEOIP_MEMORY_CACHE settings may be wrong ...

This situation is an example of how hard it could be to test plugins in various environments. What works for me may not work for you etc...

How can we make sure the plugins work for everyone? Or better yet why some work with everyone and why some don't.
If I went through a list of plugins bound for deletion and had to test them, some would not work for me but they might work for you, so it may not be a problem of the plugin...

DenisS

I tried this plugin nothing worked at all.

vrijvlinder

It works for some people , saying it does not work at all is not fair . Can you give reasons , error messages what happens ?

vrijvlinder

I was able to install and enable this plugin on another domain forum . It Bonked when I went to see the profile page . I disabled went to profile no Bonk, I enabled again and it worked.

If you run into this issue. Try disabling and then enabling while you have one window on the profile open. Then refresh to see the little flag in the about box.

When you hover the flag the name of the country pops up. The flags could be bigger I think .

Not sure why it works for some and not for others. Maybe some other plugins one might have installed may prevent or interfere.

Edit: I have enabled this plugin is 5 different installations and it works.

Srggamer

Tested this, my website went off the roof with lag, had to manually delete it from the FTP branch of plugins.

matt

Thanks for the feedback. I've been absent as was busy with work, then got married and went on honeymoon.

I'm sorry people are having issues with it. It doesn't actually do much that requires CPU or memory, so I'm a bit concerned that people are having issues.

You can substitute your own flag images (though it's tricky to find a good, complete set) or simply resize the flag image in HTML so that it is, say, double the size.

If you're still having issues, please post specific details. This plugin works for me and most other people, so it must be something specific to your setup.

Just today I have downloaded the zip and tested it and it unzipped just fine. For those who were concerned the geoip file might be platform dependent, it's not. I use a Mac as my desktop computer, and host my sites on Linux servers.

Thanks.

jeongwee

@vrijvlinder does this plugin works on 2.1b1? i tryed at my localhost but it doesnt working.

vrijvlinder

Yes it works, there are a few css modifications I made to it but that is all .

jeongwee

@vrijvlinder where to set it?.....i don see any page for set this plugin.....
the flag just not showing....
any way to make it working for me...

vrijvlinder

It appears only in the user profile , in the about section

jeongwee

still don hv flag

vrijvlinder

ok try adding this css to the plugin's css file or to the custom.css of the theme

.flag {
width: 16px;
height: 11px;
background: url('flags.png') no-repeat;
cursor: help;
float: right;
margin-right: 5px;
margin-top: 10px;
}
.flag span {
margin: 0 20px auto!important;
position: relative!important;
top: -95px;
width: 100%;
}

also try the ProfileExtender plugin it adds the location by default or other fields you may want people to fill in

jeongwee

@still doesnt working.....i used chrome broswer to check element theres no class="flag" =_=

vrijvlinder

that image only shows that the css file is being called

you need to look at the entire source

you click the area where the flag should be and inspect that part . Because the user info is not in the panel on 2.1 you need to change the css so you can see it. I am sure it is there but in the wrong place.