Errors on Vanilla 2.1RC1

fr3em1nd

Hi Thanks for this awesome plugin i got some errors on fresh vanilla 2.1 rc 1 install

Here's my server build:

Any help would be greatly appreciated

whu606

@fr3em1nd‌

Is there a reason why you aren't using the recently released Vanilla 2.1 stable?

fr3em1nd

that's what im using. it's called RC1 now.

x00

@fr3em1nd said:
that's what im using. it's called RC1 now.

Yes but using a release candidate when 2.1 has been officially released makes little sense.

fr3em1nd

?? im confused with you guys...

im using this one: http://vanillaforums.org/addon/vanilla-core

this is the release candidate the stable release for 2.1 right ??

lumio

RC is "kind of" a special beta version.
stable is more or less the version after RC.

Look at the latest version section of http://vanillaforums.org/addon/vanilla-core

peregrine

@fr3em1nd said:
?? im confused with you guys...

im using this one: http://vanillaforums.org/addon/vanilla-core

this is the release candidate the stable release for 2.1 right ??

2.1rc1 was realeased about a week before 2.1.
2.1 replaced 2.1rc1.
rc - is just another way to confuse you, a "candidate" . but not the "chosen one".

look in your index.php - if it says 2.1rc1 you re using 2.1rc1 and you should upgrade.
if it says 2.1 you are using the "Stable" recommenced version of 2.1 as of this date.

you can also see the version in the lower left corner of your dashboard.

I also believe version check plugin tells you your vanilla version as well.

fr3em1nd

define('APPLICATION_VERSION', '2.1');

i believe im using 2.1 the latest stable release

hgtonight

Thanks for reporting the error.

I will be releasing an updated version tested on 2.1 stable.

hgtonight

I just released 1.3, please let me know if that resolves your issue.

fr3em1nd

hi @hgtonight this is awesome! i got this last bug i think

hgtonight

I spent a little more time with this codebase. Could you try the latest GitHub version? https://github.com/hgtonight/Plugin-DiscussionPolls

Btw, these errors are just notices. They are definitely code smells and I really appreciate you posting them. That said, disabling debugging should remove these types of errors.

If you find anything else wrong, do let me know. If not, I will release 1.3.1 here.

Martin_Meier

I don't know if it is worth to start a new discussion so i post it here:

T('Plugins.DiscussionPolls.UnsweredAllQuestions', 'You have not answered all questions!')); T('Plugins.DiscussionPolls.UnsweredUnable', 'Unable to save!')); is it purposed to be "Unswered" without the "a"?

and how can i translate the things in this picture?

Version is 1.3

greetings

hgtonight

Thanks @Martin_Meier‌

You can currently have to translate each Option and Question (e.g. 'Option #1' = 'Answer #1', 'Option #2' = 'Answer #2', etc.) number individually. I will go ahead and fix that now.

hgtonight

1.3.2 is live in the GitHub repo.

@Martin_Meier‌ you should be able to use Question #%d and Option #%d as keys for translating the plugin. E.g. $Definition['Option #%d'] = 'Answer #%d';.

Be sure to include a %d in your definition so the right number shows up.

Martin_Meier

Thanks buddy @hgtonight‌

Martin_Meier

Sorry for the double post, but I was to late to edit

it is not ['Option #%d'], it is ['Option #%s']

I know... it was just to test my attention

Greetings

Martin_Meier

I am really to slow...

the translation works fine until I want to add more than two answers...

"Option #NaN" but I am sure 3 is a number

Greetings... again

hgtonight

I believe I fixed the translation issues. Please test out 1.3.3, live in the GitHub repo: https://github.com/hgtonight/Plugin-DiscussionPolls

Martin_Meier

Thank you @hgtonight‌ !

Cache is cleared, plugin disabled, updated and enabled...

The %s || %d "problem" is solved... but the "Option #NaN" is still the same.

Greetings

hgtonight

@Martin_Meier‌ Is it same to assume your definition is Antwort Nr.%d for Option #%d?