Please upgrade here. These earlier versions are no longer being updated and have security issues.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.

2.1 View count won't increament.

123457»

Comments

  • for what it's worth, I have a testing clone of the site and at that location I have disabled all plugins and themes - the behavior persists and is repeatable after a restore to a prior version and upgrade.

  • Gdn_Statistics_Tick_Handler is not being called...when is this expected to occur or is there another place where AddView(Discussion) should be taking place?

  • fixed what seemed like some corrupted files. I'm now getting into the discussionmodel code and it constructs fine. After it calls addview I stop getting any kind of output back but i'm not getting any errors in php logs or vanilla error_log

  • @shumoo said:
    fixed what seemed like some corrupted files. I'm now getting into the discussionmodel code and it constructs fine. After it calls addview I stop getting any kind of output back but i'm not getting any errors in php logs or vanilla error_log

    scratch that...fixed it.

    root cause is that C('Vanilla.Views.Denormalize', FALSE) is evaluating to true. I have $Configuration['Vanilla']['Views']['Denormalize'] = TRUE; in my config so I may have misunderstood how this is intended to work. It's also strange that the $increment by variable is never being updated to a non-zero value after the cache is being read. I expect something here is also failing for me. I have already overwritten everything in /applications and /library ...what else do I need to check to make sure all dependencies for this code block are covered?

  • Just updgraded to 2.1.11...

    In class.hooks.php
    ...public function Gdn_Statistics_Tick_Handler...

    $Path = Gdn::Request()->Post('Path'); error_log("Path: ".$Path); $Args = Gdn::Request()->Post('Args'); parse_str($Args, $Args); error_log("Args: ".$Args); error_log("Args Count: ".Count($Args)); foreach($Args as $Key => $Value){ error_log("Key: ".$Key." Value: ".$Value); } $ResolvedPath = trim(Gdn::Request()->Post('ResolvedPath'), '/'); error_log("ResolvedPath: ".$ResolvedPath); $ResolvedArgs = @json_decode(Gdn::Request()->Post('ResolvedArgs')); error_log("ResolvedArgs: ".$ResolvedArgs); $DiscussionID = NULL; $DiscussionModel = new DiscussionModel();
    [26-Jun-2015 19:04:32 UTC] Path: discussion/406/raid-progression-schedule
    [26-Jun-2015 19:04:32 UTC] Args: Array
    [26-Jun-2015 19:04:32 UTC] Args Count: 0
    [26-Jun-2015 19:04:32 UTC] ResolvedPath: vanilla/discussion/index
    [26-Jun-2015 19:04:32 UTC] ResolvedArgs:

    // Discussion link elseif ($ResolvedPath == 'vanilla/discussion/index') { $DiscussionID = GetValue('DiscussionID', $ResolvedArgs, NULL); }
    [26-Jun-2015 19:04:32 UTC] DiscussionID:

    Viewcounts are not incrementing again due to DiscussionID being unset.

  • if(get_magic_quotes_gpc() == 1) {
                $ResolvedArgs = @json_decode(stripslashes(Gdn::Request()->Post('ResolvedArgs')));
            } else {
                $ResolvedArgs = @json_decode(Gdn::Request()->Post('ResolvedArgs'));
            }
    

    from
    http://vanillaforums.org/discussion/25815/view-counter-works-with-apache-prefork-mpm-but-not-worker-mpm

    resolves the issue

  • Also just for context I turned off magic quotes gpc and I started getting php parse error spam like this:

    PHP Parse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING in /www/plugins/EventCalendar/class.eventcalendar.plugin.php on line 172

Sign In or Register to comment.