Upgrading Markdown lib

JasonBarnabe

(I'd post this in Development, but I can't, apparently)

Vanilla 2.1.3 and what's in master in GitHub use PHP Markdown 1.0.1n/Extra 1.2.4. It was upgraded 1.0.2/Extra 1.2.8, but then reverted. The latest version is 1.4.1 (the versioning scheme seems to have changed).

My users would like to use certain Markdown features available in 1.4.1, like fenced code blocks. I can upgrade it myself easily enough, but I'm concerned that there was something incompatible with the newer versions. @Linc or someone else, can you tell me why it was downgraded?

hgtonight

There was a discussion last month that prompted this issue to be filed: https://github.com/vanilla/vanilla/issues/2045

JasonBarnabe

I guess this was it?

Linc

@JasonBarnabe‌ My upgrade undid some customizations we'd made to the current version, and I didn't implement the GitHub-flavored line breaks correctly. My issue notes were:

• Newline preservation I added is causing extra br's inside 'pre' tags.
• git log -- library/vendors/markdown to find our customizations
• Possible issue with Emotify not matching at end of lines

My notes for remedying this in the next upgrade attempt were:

• put the newline stuff in doHardBreaks()
• test thoroughly on complex examples of Markdown posts

If you want to try to accomplish all that, I'd be delighted.

Feel free to start a feature branch & open a pull request, and I'll contribute as I'm able. You don't need to have it complete before opening the pull request; just leave comments to let us know where you are.

Linc

@JasonBarnabe‌ Also, added you to the Developer role. Just me not being quick on the draw.

JasonBarnabe

Well, I don't care much about line breaks for poetry, but I may take a stab at upgrading the library while maintaining the current customizations.

JasonBarnabe

See https://github.com/vanilla/vanilla/pull/2138

Linc

We merged this one: https://github.com/vanilla/vanilla/pull/2203

And now I've added: https://github.com/vanilla/vanilla/pull/2221