Testing 2.1.4

Linc

Can folks give this a spin quick tonight?

https://github.com/vanilla/vanilla/archive/2.1.zip

Wanna clear this for release ASAP.

Schryvers

http://vanillaforums.org/discussion/28326/activationlink-strange-bug

included?

Linc

No, that's the first time I've seen that discussion. I don't mind including it if someone sends me a PR tonight & verifies it doesn't break anything.

Bleistivt

Probably needs more testing, this was originally added here:

https://github.com/vanilla/vanilla/commit/0fae36

As I understand, you are using sendgrid for the hosted service?

Bleistivt

A phpMailer upgrade should solve this:

https://github.com/PHPMailer/PHPMailer/issues/215

I'll file it on github, so it makes it into the next version

Bleistivt

Regarding 2.1.4:

I've been testing a bit and everything looks ok. The cleditor fix works, but when you disable it, comments created with cleditor will lose their styling, even things like bold and strikethrough.

Not really tragic in my opinion, way better than permanently overriding the SafeStyles setting.

Linc

@Bleistivt said:
Regarding 2.1.4:

I've been testing a bit and everything looks ok. The cleditor fix works, but when you disable it, comments created with cleditor will lose their styling, even things like bold and strikethrough.

Not really tragic in my opinion, way better than permanently overriding the SafeStyles setting.

Thanks!

I agree the cleditor / SafeStyles fix isn't ideal, but I think it's probably an OK tide-over for a better solution in 2.3.

hgtonight

I have been testing it a little bit using this diff as a guide to what needs to be tested: https://github.com/vanilla/vanilla/compare/df1476510310939965feb1f4fb713eef5e372e99...2.1

Everything is working as far as I can tell.

vrijvlinder

@Bleistivt said:
Regarding 2.1.4:

I've been testing a bit and everything looks ok. The cleditor fix works, but when you disable it, comments created with cleditor will lose their styling, even things like bold and strikethrough.

Not really tragic in my opinion, way better than permanently overriding the SafeStyles setting.

To me it is a big thing and I would not want to disable style tag or have any or all posts made that have style lose their style.

That to me is a catastrophe .

People put time into it and they would be very mad if their work was nulled. I can't make use of something so stringent. Not for my purposes.

Can this be a deal breaker and cause people to go to other forums ? It will be interesting to see.

Linc

@vrijvlinder said:
I can't make use of something so stringent. Not for my purposes.

1. There's currently no reason to disable cleditor if you're using WYSIWYG.
2. You can build a 4-line plugin that disables SafeStyles again. What we're doing here is making the default safe.

vrijvlinder

I think that is what I will need to do , there should be an alternative.