Embed comment Wordpress glitchy

Gogito

So, I've enable embed comment and everything seems to be working except that it doesn't look right.

Bleistivt

Welcome to the community!

That's an issue with the Bootstrap theme, it doesn't support embedded comments yet:

https://github.com/kasperisager/vanilla-bootstrap/issues/96

If you could post a link to your site, we could take a look, it may just be a few lines of CSS you'd have to add.

Gogito

Ok
Here it is
http://mmo4teen.com/making-money-online-monthlyyouth/

Gogito

Anyone ?

whu606

You need to provide a test user account. Guests can't comment, so can't see the issue.

Gogito

Oh
Try
User: 1
Pass: 123456

Or you can login with facebook or twitter

Gogito

Has anyone figure it our yet ? I can't seem to find what css is controlling it.

Bleistivt

This gets quite messy, I'd rather wait for @Kasper to implement styling for embedded comments.

I propose a different solution - revert back to the default style for embedded comments:

<?php if (!defined('APPLICATION')) exit();

$PluginInfo['EmbedDefaultStyle'] = array(
    'Name' => 'EmbedDefaultStyle',
    'Description' => 'Reverts to the default style for embedded comments.',
    'Version' => '1',
    'Author' => 'Bleistivt',
);

class EmbedDefaultStylePlugin extends Gdn_Plugin {

    public function Base_AppStartup_Handler($Sender) {
        if (strpos(Gdn::Request()->Path(), 'discussion/embed') !== false)
            SaveToConfig('Garden.Theme', 'default', false);
    }

}

Gogito

@Bleistivt said:
This gets quite messy, I'd rather wait for Kasper to implement styling for embedded comments.

I propose a different solution - revert back to the default style for embedded comments:

<?php if (!defined('APPLICATION')) exit();

$PluginInfo['EmbedDefaultStyle'] = array(
'Name' => 'EmbedDefaultStyle',
'Description' => 'Reverts to the default style for embedded comments.',
'Version' => '1',
'Author' => 'Bleistivt',
);

class EmbedDefaultStylePlugin extends Gdn_Plugin {

  public function Base_AppStartup_Handler($Sender) {
      if (strpos(Gdn::Request()->Path(), 'discussion/embed') !== false)
          SaveToConfig('Garden.Theme', 'default', false);
  }

}

How do I implement that ?

R_J

That's a plugin called "EmbedDefaultStyle". Save it to /plugins/EmbedDefaultStyle/class.embeddefaultstyle.plugin.php and then you can activate it in the dashboard

Gogito

I tried it but when I activate it, I get "error". Can you upload the ready-made version of it. Like in zip form thatonly needs to be extract to the folder.

daedeloth

I have had the same problem and I have created a patch for it, allowing you to select a specific theme for everything embedded.
It's not in the main repo (yet?), but you can find the whole thing here: https://github.com/CatLabInteractive/vanilla

Please note that I could not put this in a plugin; it's a patch.

Bleistivt

Please, always post the actual error messages you get.

hgtonight

@Bleistivt said:

I propose a different solution - revert back to the default style for embedded comments:

After looking into this, this is not a sufficient solution. You need to unregister the current theme's hooks file from the plugin manager. Then you need to register the new theme's hooks file if you want to change to a theme that has one.

Bleistivt

I know, but it should be sufficient for the discussion/embed view if the base theme is bootstrap

Gogito

Thanks a lot, it worked.

Gogito

@Bleistivt said:
Please, always post the actual error messages you get.

I've just checked again and it seems not to be working with mobile, what should I do to make it work ?

Bleistivt

@Gogito said:
I've just checked again and it seems not to be working with mobile, what should I do to make it work ?

Add "MobileFriendly" => true, to the PluginInfo array (insert after line 6 for example)

Gogito

@Bleistivt said:
Add "MobileFriendly" => true, to the PluginInfo array (insert after line 6 for example)

Thanks a lot @Bleistivt, it worked perfectly.

Gogito

Well, I've checked again and now it's not working with mobile anymore. @Bleistivt Can you help me again ?

Gogito

On second thought, I guess I'm gonna work with the actual CSS of bootstrap to fix this, my css skill has imporved a bit thanks to you guys