@businessdad said:
No chagrin. "StegoCase" is ok to read, unlike camelCase (it's one of my pet peeves about Java[Script]). I've never seen a database using camelCase, and I hope that I will never do.
Yeah not hot on camelCase. I think underscores are best for readability, you don't have issue with acronym and double letters. I was initially averse and now totally won over. Title case for classes, and underscores for method properties and functions, All caps an underscore for constants.
I admire the python community, for setting an overall standard. Switching between standards, is a pain. There is something to be said for strictly enforcing a syntax after it is established. There is too much time wasted on stuff like this.
Talking about conventions, there is no locale namespaceing. Sometimes I use a prefix with a dot. Locale namespacing is useful especially with common words.
Can you say anything about the progress of the code change?
From time to time I see things that need to be changed (e.g. the anchor function seems to be lower case in all Vanilla applications files but not yet in the plugins)
I'm unsure if I shall create PRs because of some StegoCases I find or just wait until you say "finished!" Is there a date planned like "before 2.2rc1" or something like that?
Comments
Why did you get rid of the include guards?
My themes: pure | minusbaseline - My plugins: CSSedit | HTMLedit | InfiniteScroll | BirthdayModule | [all] - PM me about customizations
VanillaSkins.com - Plugins, Themes and Graphics for Vanillaforums OS
Our preference would be all lowercase.
Not sure what change that is in reference to.
@Linc the
exit();on top of every file. But I just noticed that files with side effects (views) still have them which is a good thing.My themes: pure | minusbaseline - My plugins: CSSedit | HTMLedit | InfiniteScroll | BirthdayModule | [all] - PM me about customizations
VanillaSkins.com - Plugins, Themes and Graphics for Vanillaforums OS
Right, we removed those checks for files that contain only declarations. There wasn't really any benefit there.
phpBB also doesn't use the defined/exit on classes like linc says there is no point.
grep is your friend.
All is merged.
Exciting!
There were only 5 typos and only 1 of them was a maddening, hours-long debug.
Yeah not hot on
camelCase. I think underscores are best for readability, you don't have issue with acronym and double letters. I was initially averse and now totally won over. Title case for classes, and underscores for method properties and functions, All caps an underscore for constants.I admire the python community, for setting an overall standard. Switching between standards, is a pain. There is something to be said for strictly enforcing a syntax after it is established. There is too much time wasted on stuff like this.
grep is your friend.
That is why we've switched to PSR-1 and PSR-2 (mostly), the generally agreed on PHP community standards now.
Talking about conventions, there is no locale namespaceing. Sometimes I use a prefix with a dot. Locale namespacing is useful especially with common words.
grep is your friend.
Can you say anything about the progress of the code change?
From time to time I see things that need to be changed (e.g. the anchor function seems to be lower case in all Vanilla applications files but not yet in the plugins)
I'm unsure if I shall create PRs because of some StegoCases I find or just wait until you say "finished!" Is there a date planned like "before 2.2rc1" or something like that?
We're done with the sweeping change for now. Fix 'em as you find 'em in code you change.