HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.

Upload New Addon, Github is required

jackmaessenjackmaessen ✭✭✭
edited March 2016 in General Banter


Do not know what this means but it is impossible to add a new addon because in red appears "Github is required" when i submit. Do not know how to handle with this info

Comments

  • vrijvlindervrijvlinder Papillon-Sauvage MVP
    edited March 2016

    It means it must state the license you are releasing it under. I use this one 'License'=>"GNU GPL2",

    $PluginInfo['NameofPlugin'] = array(
       'Name' => 'NameofPlugin',
       'Description' => 'description',
       'Version' => 'versionx',
       'SettingsUrl' => 'ifany',
       'SettingsPermission' => 'ifany', 
       'License'=>"GNU GPL2",
       'Author' => "you"
    );
    
  • Hmm...this is my plugininfo and i got still the same issue:

    // Define the plugin:
    $PluginInfo['BootstrapThemeSwitchLayout'] = array(
       'Name' => 'BootstrapThemeSwitchLayout',
       'Description' => "Switch Layout of Bootstrap Theme for users",
       'Version' => '1.0',
       'Requires' => 'Bootstrap Theme', 
       'HasLocale' => FALSE,
       'License'=>"GNU GPL2",
       'Author' => "Jack Maessen" 
    );
    
  • vrijvlindervrijvlinder Papillon-Sauvage MVP

    You also need to make an account at github ? and link it to your account here...

    https://github.com/vanilla

  • This is a little bit strange. With the other plugins i made, this was never an issue.
    @Linc Maybe you can explain this to me and what should i do to upload a new addon? I need to create an account on Github? And link it somewhere in the addon?

  • hgtonighthgtonight ∞ · New Moderator
    edited March 2016

    @jackmaessen said:
    This is a little bit strange. With the other plugins i made, this was never an issue.
    @Linc Maybe you can explain this to me and what should i do to upload a new addon? I need to create an account on Github? And link it somewhere in the addon?

    This is a recent change to the community repo. GitHub shouldn't be required though, let me take a look at it.

    EDIT: https://github.com/vanilla/community/pull/92

    Search first

    Check out the Documentation! We are always looking for new content and pull requests.

    Click on insightful, awesome, and funny reactions to thank community volunteers for their valuable posts.

  • R_JR_J Ex-Fanboy Munich Admin

    @hgtonight said:
    GitHub shouldn't be required though

    I can understand why it shouldn't be required, since it would raise the hurdle to contribute plugins for occasional coders.

    But have you - as an addon contributor - already spoke about that with @Linc and @Todd? Do you know about the Vanillas staff opinion on that topic? I think it should be considered to make GitHub (or BitBucket or any other OS repository hosting service) mandatory.
    I'm convinced that in the long run, it would help improving the plugins quality.

  • LincLinc Detroit Admin

    Yeah that was a coding mistake, sorry. I manually changed it in the database. I actually fixed it on master branch before I read the discussion and saw @hgtonight's fix, my bad.

  • LincLinc Detroit Admin

    @R_J said:
    I think it should be considered to make GitHub (or BitBucket or any other OS repository hosting service) mandatory.

    We may, but I'd rather we have some better integration with GitHub first.

  • jackmaessenjackmaessen ✭✭✭
    edited March 2016
  • rbrahmsonrbrahmson "You may say I'm a dreamer / But I'm not the only one" NY ✭✭✭

    I don't know how you uploaded it but I just tried to upload a new plugin and I got the same error message. The $PluginInfo has " 'License'=>"GNU GPL2"".

    How do upload the plugin?

  • vrijvlindervrijvlinder Papillon-Sauvage MVP

    Look for typos or errors in that…

  • rbrahmsonrbrahmson "You may say I'm a dreamer / But I'm not the only one" NY ✭✭✭
    edited March 2016

    Thanks @vrijvlinder. Nothing rings a bell... I was able to upload other plugins... This is has not happened to me before...

    $PluginInfo['DiscussionReaders'] = array(
        'Name' => 'Plugin Info',
        'Description' => 'Plugin Description.',
        'Version' => '1.1.0',
        'RequiredApplications' => array('Vanilla' => '2.1.13'),  //My testing environment//
        'RequiredTheme' => FALSE,
        'MobileFriendly' => TRUE,
        'HasLocale' => TRUE,
        'SettingsUrl' => '/settings/DiscussionReaders',
        'SettingsPermission' => 'Garden.Settings.Manage',
        'RegisterPermissions' => array('Plugins.DiscussionReaders.View'),   
        'Author' => "Roger Brahmson",
        'License' => "GNU GPL2"
    );
    

    @Linc - how do I upload the plugin without setting up github?

  • LincLinc Detroit Admin

    Fixed again. Sorry, I never pulled the new version of the code so utility/update kept resetting it. I actually deployed it this time.

  • rbrahmsonrbrahmson "You may say I'm a dreamer / But I'm not the only one" NY ✭✭✭

    @Linc, what have you done? Two mistakes in a row? Until now I considered you as one of the Titans, unearthly coders from the planet of Vanillium in the MVC Galaxy, descendant of the King of PHP and Queen CSS. Now I suspect that you are merely mortal, capable of errors. That is very encouraging because that is a level I can aspire to achieve.

    In short, thanks!

  • LincLinc Detroit Admin

    Oh man. The errors I've made. Epic stories for the bar.

Sign In or Register to comment.