Blog Documentation Book a Demo
Vanilla 1 is no longer supported or maintained. If you need a copy, you can get it here.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.

[Extension] Comment Links 1.3.2

2

Comments

  • SlashedZeroSlashedZero
    Thanks for these details, I'm looking forward to the next release :)
  • squirrelsquirrel
    edited February 2007
    Strangely, it works fine in Safari but does not work in Firefox 2.0.0.2 on Mac OS X 10.4.8.

    That is to say, the menu works but nothing gets copied to the clipboard.

    edit: ahh, that would be because Firefox disallows clipboard access by scripts...
  • WandererWanderer
    edited February 2007
    I'm running Firefox 2.0.0.1 and it works well on my forum, is this a new development in Firefox 2.0.0.2?
    It does not work at all here on Lussumo because the extension (broken version) has still not been updated.

    Posted: Tuesday, 27 February 2007 at 5:42PM (AEDT)

    Later...
    OK I updated to Firefox 2.0.0.2 and Comment Links v1.3.1 still works perfectly.

    Posted: Tuesday, 27 February 2007 at 5:50PM (AEDT)

  • WallPhoneWallPhone
    Although, it should work.

    I have personally tested with Opera 8.5, 9, IE 6, 7, FF 1.5 and 2 on Windows XP, as well as FF 2 and Konqueror on Ubuntu 6.10.

    Both IE 7 (with a nag dialog) and FF (allowed with a buried preference) are supposed to prevent clipboard access with Javascript. But there is a loophole if you pass that information through Flash.

    If your Firefox has flash installed, it should copy.
  • squirrelsquirrel
    Ahhh, I do have Flash but I also have Flashblock. This is probably an unfixable problem for me, unless we can get a law passed mandating the death penalty for serving pop-up Flash adverts.

    Is there an option in this extension for the "dumb way" that ditches the menu and simply gives each comment a permalink to itself? That way I could just right-click and select "Copy Link Location".
  • WallPhoneWallPhone
    Yah, you can do that with the gray link that normally pops the menu--works for those without Javascript too :-)

    As far as flashblock, it looks like it leaves a placeholder if you want to allow a flash to run... I could try putting it in a visible area, like right under the menu instead of a hidden div offpage... would that at least let you allow it to run in flashblock?
  • squirrelsquirrel
    Yah, you can do that with the gray link that normally pops the menu

    Well... yeah! If I wanted to be obvious about it! Pshh! [runs away] [hides]

    Honestly I wouldn't bother trying to hack around Flashblock. I don't think it's common enough to justify adding more complexity to the extension, especially when relief is just a right-click away.
  • Andy KAndy K ✭
    Hey all, I'm noticing the same problem that tcorbet noticed above. Baiscally, I've got the latest Vanilla (1.1.1), and the latest Comment Links (1.3.1), and when I enable Comment Links I notice that immediately all the radio buttons like "Text", "HTML", BBCode" etc disappear after "Format comments as". If I re-edit a post I already made, they appear, but they cannot be seen in new posts.

    Is there a fix for this yet? Thanks!
    -Andy
  • StashStash ✭
    Andy K, I've just noticed that I have the same problem on my test forum as well. I only get the formatter options on a post edit or a new discussion.
  • WallPhoneWallPhone
    That bug was supposed to be squashed in beta. It seems iterating through the installed formatters moved the array cursor and then Vanilla started to read the array from its end instead of the beginning.

    Apparently some versions of PHP handle my workaround differently. You should be able to fix this by inserting reset($Formatters); on line 45 (right after the foreach loop).
  • StashStash ✭
    I can confirm this does the trick, thanks WallPhone :) Will you update this in the extension download?
  • WallPhoneWallPhone
    this is a hack that fixes symptoms caused by a hack... so the next update simply removes the first hack.

    I am working on getting this to work with Userinfo Tooltip, and will post an update when that is done.
  • BassettsBassetts
    I still have no "Format comments as" radio buttons when using this extension. I have tried the fix you suggested also.
  • WallPhoneWallPhone
    OK, I uploaded a new version that should fix the disappearing options. There is also an attempted fix for a Safari bug that keeps the menu from appearing a second time once it has been opened and closed.

    This doesn't fix the JQ Thickbox or Userinfo Tooltip conflicts that I am still researching.
  • BassettsBassetts
    I have tried the new version and the "Format comments as" radio buttons now show but when I click the link to display the menu it just gets stuck saying "Loading"
  • WallPhoneWallPhone
    Grrr... What version of PHP?
  • BassettsBassetts
    It is running 5.2.1. It is not my public server just a development one but I guess other people could be running a similar setup.
  • WallPhoneWallPhone
    I forgot some quotes, workes now.
  • BassettsBassetts
    I shall upload it in a few minutes and let you know how it goes. I keep forgetting what I am doing let alone a few quotes, long day :-(
  • BassettsBassetts
    Working fine now. Thank you very much.
This discussion has been closed.