Vanilla 1 is no longer supported or maintained. If you need a copy, you can get it here.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.
GuestPost v1.3
This discussion has been closed.
Comments
1) Wonder why the
DiscussionForm_SignOutGuest
delegate tests for whether the user is logged in as Guest. The delegate is registered onlyif ($Context->Session->UserID <= 0)
.Edit: I see, it also logs users out if the test is left in. However, even if I set $GU with the constant value, the test always fails?
Proposed fix:
$Username = ForceIncomingString('Username', ''); $Password = ForceIncomingString('Password', ''); if ( $Username == '' ) { $Username = GuestUsername; $Password = GuestPassword; define('IS_GUEST', 1); }
and
if (defined('IS_GUEST')) { $DiscussionForm->Context->Session->End($DiscussionForm->Context->Authenticator); }
2) At the time the comment is posted, the poster is auth'ed as Guest and if an error occurs, the top-right area shows . If
DiscussionForm_SignOutGuest
does not log the user out as pointed out in 1), the user is still logged in!3) Aside from issues raised by others above, what about spam protection as set in Application Settings (Members cannot post more than comments within x seconds)? Does it mean if two or more users post independently, they may see the blocking message?
1) I'm not really sure what you mean...? It tests to see if the user is logged in as a guest so that if a user uses the forum to login to their account it doesnt log them out once the post is completed. Were you aware of that functionality? What did you mean by the test failing? At the point the delegate is called the user is 'registered' because they havent been logged out yet. I hope that covers your question cause otherwise i'm confused.
2) Can't really think of a work-around for that yet but it is a bit of an issue...ideas anyone?