Best Of

I like that idea very much. The two factor authentication idea is all around, but I think for forums there is a benefit if registration is as easy as possible "Login in with service XY" SSO solutions are a great way to deal with it, and being able to simply use your mail without setting up a social media account is a nice idea.

The plugin doesn't offer a "register with fast.co" option, though. Only signing in with an existing account seems to be supported. I think it should also be usable to make registration more easy. Since your service doesn't store any information, the only thing which can be made more easy would be to make the password fields superfluous.

But there are several (major) problems with the current implementation (in the order of appearance):

1. The plugins file name should be named like the class name.
2. When the plugin is enabled, the administrators mail address is automatically sent to your APIs /enroll endpoint. Sending private data without giving the user the choice to do so is a no go.
3. Since the admin user is not even notified about the account that has been created with this mail address he cannot even use it to look at the statistics; the mail used for that auto-enrollment is communicated
4. Buttons are HUGE. It's that big, that even your "Fast" logo needs to get truncated in the panel. If they are used together with other social network logins, they shouldn't be as big as that, but only a small icon, too.
5. If there is that FAB like login button, which helps you at any point to log in, I would have the expectation that after logging in I would be redirected to that page again, but as far as I understood, that is not yet working
6. "As far as I understood", because in my setup, a forum behind a proxy secured with basic auth, the button loading api crashes my site as soon as I login and I never see anything different than "transferring data from api.fast.co" and as a result "a website is slowing down your browser"

By the way: that handy api.fast.co/api/enroll endpoint allows using parts of your services with unauthorised mail addresses. I suggest to send a "to finish your enrollment process click here" mail which - well authorises an automagical enrollment

Figured it out

in /design/search-style.css you got capital B both places

.SearchForm .Button, .search-form .Button

search-style.css should be

.SearchForm .Button, .search-form .button

May I suggest adding

.Button:hover, .button:hover{
  filter:brightness(0.7); 
}

I understand these kind of announcements have been kind of ad-hoc in the past, but I'd like to do them more frequently in the future. My intention is to outline in broad strokes what features and parts of the framework we'll be working on in the next few months.

Warning: These notes are not a guarantee of any particular version number or release date. It just represents some of our development goals. In particular any of these numbered releases may be broken up or shifted if we make an extra release.

Primary Goals

• Add some small new features.
• Clear our Low/Medium security backlog.
• Wrap up various on-going technical projects.

Vanilla 3.2

• New Content Embed System & Documentation. See OSS preview + announcement thread.
• User homepage selector plugin.
• Enhanced automated testing on pull requests with CircleCI.
• Various Rich Editor & Forum bug fixes.
• Low/Medium severity security fixes from the backlog.

ETA End of July

Vanilla 3.3

This one likely won't be clarified until after a few more product team meetings.

Rich Editor

• Alt-text for images.
• Better handling of embeds on mobile devices.

Routing

The team has been doing a lot of work over the last few months on a new base controller, and static routing system. A lot of the interface and classes used here are already development but may change between now and the release where they are publicly documented.

Builtin Docker Images

Vanilla currently has a project, vanilla-docker that is used for all of our team's development environment. These images are planned to be moved into the core repo, and have all dependencies placed inside. This will also include a production configured image & setup script for hosts that support Docker (looking at an installer for digital ocean).

Using this system the only dependency will Docker. All other tooling (php, composer, node, yarn, etc) will run inside of the containers.

Formatting Pipeline

Work has begun on a major refactoring of the text rendering pipeline. The goals being:

• Consistent interface for different formatters.
• Unified configuration options between Rich Editor & other formats.
• Configuration options for embeds.
• Break up Gdn_Format
• Increased automated test coverage.

JS module system

We've begun breaking up our core typescript codebase into individual packages and publishing them to NPM. These will be published under the org. The intention is to consolidate various packages & build processes floating around.

ETA End of August

Good work.

Here is another semi major issue.

The plugin does not signify the search section name. Inspect the body element in the browser, this is missing 'Section-SearchResults'.

So, any custom smarty logic in the theme or another PHP plugin or even mere CSS rules that depend on Section-SearchResults, will ultimately fail.

Example of codes that will fail

.Section-SearchResults .SiteSearch{
 display:none;
}

or

if(inSection('SearchResults')){
  echo 'super duper js code';
}

Solution:

In class.filterforumsearch.plugin.php, insert the line within the function SearchController_Render_Before

Gdn_Theme::section('SearchResults');

Also, I suggest removing the label for the search field, vanilla does not come with one, and it is rather obvious what the search field is used for. A more common method is using a placeholder.

The above cleanup would prevent this glitch

direct css injection is deprecated, you should

in class.filteredforumsearch.plugin

replace

$Sender->AddCssFile($this->GetResource('views/style.css', FALSE, FALSE));

by

$Sender->addCSSFile('style.css', 'plugins/FilteredForumSearch');

and put style.css file in a design folder

That's all thank you for this plugin!