Best Of

Re: Feed discussions plugin seemingly not working

Thank you for your feedback, I hope Vanilla staff will fix this plugin soon. I tried also FeedDiscussionsPlus is ok but I am not that really pleased with the result... I get sort of error message in every post created from rss: _Imported from a malfunctioning feed________

Ionmarcu

1 ·

What license is jsConnectJava?

Hi All,

I'm a big fan of vanilla forums and have been running them for several years. We are considering using jsConnect and jsConnectJava (https://github.com/vanilla/jsConnectJava), but before doing that I was curious what is the software license for jsConnectJava. It isn't explicitly noted in the github repo, and I am wary of importing GPL2 code into a proprietary web application.

Thanks and regards,
Jason

JasonF

1 ·

Re: Fix for wrong URL error

Just because something is in the vanilla/addons repository does not mean that it is heavily used or tested on Vanilla cloud in the same scenarios that are found in open source installations. In this case @R_J submitted the fix rather easily directly through Github.

As far as backports/releases go, this type of change could be backported to the previous release by doing the following locally, but we are very unlikely to accept backport pull request for something that never had an issue in our github repo, and didn't have discussion prior of why the change should be backported. But for doing so the process looks like the following:

Get the short hash of the commit you want to backport by using git log. It can also be seen in the commits view a pull request on github. In this case it is 7699791
Checkout the release/2.5 branch

cd /my-repos/vanilla
git checkout release/2.5

Checkout a backport branch

git checkout -b backport/605

cherry-pick the commit

git cherry-pick 7699791

Make PR to release/2.5 branch.

charrondev

1 ·

Re: Fix for wrong URL error

I can surely do this, but here are some thoughts to this...

Why should it be me? The repo is here and everybody with a GitHub account can do it. It is an easy fix and from my own experience I can tell that is damn satisfying to see your own name in the list of contributors. So anybody who reads this: GO! GO! GO! Hurry up to be the first!
Such a small fix could be done very easily in the GitHub online editor.
It should be backported to the 2.5. If I remember correctly, that is done by something git calls "cherry picking", but I'm not sure if this is the correct term and if this is also possible with the GitHub interface.
If the plugin available here in the download section should be updated afterwards, there should be some people acknowledging that the GitHub version from branch 2.5 is working with Vanilla 2.5.1

R_J

1 ·

Addon directory fixes

Hey guys,

The addon directory has some issues:

If you go to an addon download page, the link to the author is broken (because the output of UserUrl is needlessly escaped again, even though userURL already sanatizes dangerous input).
It completely ignores addon.json files in your zip file and it requires a PluginInfo array in your plugin file (even though that approach is deprecated). See this issue: https://github.com/vanilla/community/issues/135
If your main class is class.Fancyplugin.php, it fails because it requires either class.FancyPlugin.plugin.php or default.php
Plugins, applications and themes are now all addons. But there is no general addon type, so even if the addon directory would parse the addon.json file correctly, it wouldn't work because it has no type to file it under.

I think I fixed these various issues, but does someone have time to try out the fix / check the style requirements before I create a pull request?
https://github.com/Caylus/community

Caylus

11 ·

Re: /tmp being filled with files called atomic*

I'm quite convinced that you are using /tmp as the cache folder. The AddonManager has changed very much and this seems to be a bug.
While it shouldn't be a problem to use another folder than /cache, by now it is a problem. I've reported that on GitHub.

You could "solve" your problem now, by either using Vanillas default cache folder or by creating a /tmp/vanilla folder and use a symlink to this folder for caching.

R_J

1 ·

Re: 2.5 dashboard organization

@rbrahmson said:
IMHO the presumption is that (1) You will find a solution to the difficult design issue, and (2) that whatever your decision will be, it will satisfy every admin out there who may have their own view and workflow.

I would say the goal is to not shirk the challenge of number one, and we're not deluded into thinking two is possible. Abdicating design decisions creates more complex software, which in other discussions you'll then lambast us for not maintaining its backwards compatibility perfectly with our available resources.

Criticism-based discussions on this site often seem to start with a shake of the mental Etch-A-Sketch, discarding all the connections and limitations of the last discussion. It's my team's job to never do that. Coding is the easy part.