Please upgrade here. These earlier versions are no longer being updated and have security issues.
HackerOne users: Testing against this community violates our program's Terms of Service and will result in your bounty being denied.

submit comment creates new comment box, without submitting

1246

Comments

  • peregrineperegrine MVP
    edited November 2013

    I logged in added a bunch of comments, couldn't reproduce. deleted my comment.

    searched around and saw you had some plugins enabled and other js.

    do you use stop autodraft, you might use that on the live site if you don't already

    here's what I saw on a good comment post.

    {"Targets":[{"Target":"","Data":"\/vanilla\/post\/comment2\/19\/1","Type":"Ajax"}],"CommentID":"19","DraftID":"","MyDrafts":"My Drafts","CountDrafts":0,"FormSaved":true,"DeliveryType":"VIEW","Data":"PGxpIGNsYXNzPSJJdGVtIENvbW1lbnQgTWluZSBBbHQiIGlkPSJDb21tZW50XzE5Ij4KICAgPGRpdiBjbGFzcz0iQ29tbWVudCI+CiAgICAgIDxkaXYgY2xhc3M9Ik1ldGEiPgogICAgICAgICAgICAgICAgICA8c3BhbiBjbGFzcz0iQXV0aG9yIj4KICAgICAgICAgICAgPGEgaHJlZj0iL3Byb2ZpbGUvMS9UVVNFUiI+VFVTRVI8L2E+ICAgICAgICAgPC9zcGFuPgogICAgICAgICA8c3BhbiBjbGFzcz0iRGF0ZUNyZWF0ZWQiPgogICAgICAgICAgICA8YSBocmVmPSIvZGlzY3Vzc2lvbi9jb21tZW50LzE5I0NvbW1lbnRfMTkiIGNsYXNzPSJQZXJtYWxpbmsiIG5hbWU9Ikl0ZW1fMTQiIHJlbD0ibm9mb2xsb3ciPjE6NTlBTTwvYT4gICAgICAgICA8L3NwYW4+CiAgICAgICAgIDxzcGFuPjxhIGhyZWY9Ii92YW5pbGxhL3Bvc3QvZWRpdGNvbW1lbnQvMTkiIGNsYXNzPSJFZGl0Q29tbWVudCI+RWRpdDwvYT48L3NwYW4+PHNwYW4+PGEgaHJlZj0iL3ZhbmlsbGEvZGlzY3Vzc2lvbi9kZWxldGVjb21tZW50LzE5L1REQjFJNUVTS1BBWD9UYXJnZXQ9JTJGZGlzY3Vzc2lvbiUyRjElMkZ4IiBjbGFzcz0iRGVsZXRlQ29tbWVudCI+RGVsZXRlPC9hPjwvc3Bhbj4gICAgICAgICA8ZGl2IGNsYXNzPSJDb21tZW50SW5mbyI+CiAgICAgICAgICAgICA8YSBocmVmPSIvdXNlci9icm93c2U\/a2V5d29yZHM9MjE2Ljk5LjE5OC41MiI+MjE2Ljk5LjE5OC41MjwvYT4gPGRpdiBjbGFzcz0iVXNlckF3YXJkc1Njb3JlIj48c3Bhbj40MjAgUG9pbnRzPC9zcGFuPjwvZGl2PiAgICAgICAgIDwvZGl2PgogICAgICAgICAgICAgICA8L2Rpdj4KICAgICAgPGRpdiBjbGFzcz0iTWVzc2FnZSI+CgkJCXRlc3QJCTwvZGl2PgogICAgICAgICA8L2Rpdj4KPC9saT4K","InformMessages":[],"ErrorMessages":"","RedirectUrl":""}

    two posts per post of comment

    http://test1.homebrewforums.net/vanilla/post/comment/1

    http://test1.homebrewforums.net/vanilla/post/comment2/22/1

    is it possible you have so much traffic that there is a timeout

    when it fails - is the first post response OK.


    when it fails....
    maybe you can post the header and response if any of the the one or two jqueries it might give some insight and look at the reponse time. maybe it times out on first jquery.

    also if you could look in log to see how many web page hits at that moment of time.

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • my web traffic is not very high, my server load is down in the noise floor for two pieces of dedicated hardware.

    "do you use stop autodraft, you might use that on the live site if you don't already" i have that enabled on the live site. the only thing that is currently enabled on the test site is the awards plugin and it's prereqs. everything else is disabled.

    i posted the header information for good and bad posts on this discussion. I didnt find a smoking gun. the responses are all OK. I see no failures in the requests, no JS Errors, and no errors in the apache logs.

  • peregrineperegrine MVP
    edited November 2013

    kind of tough to figure out an intermittent problem on your test site when the problem is not occurring. maybe when your test site has the issue again and is more constant you could post. I know I used to see duplicate comment boxes periodically on this vanilla forum and others in the past (I have slow connection and things were timing out). But don't recall the problem recently.

    But you say it is malformed header (or whatever) and doesn't seem like a timing issue.

    So what would cause it to be malformed (jquery and its libraries json, possibly other jqueries interfering) just rambling...

    incoming inform message and notification???

    are you still using the same version of php?

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • @peregrine said:
    kind of tough to figure out an intermittent problem on your test site when the problem is not occurring. maybe when your test site has the issue again and is more constant you could post. I know I used to see duplicate comment boxes periodically on this vanilla forum and others in the past (I have slow connection and things were timing out). But don't recall the problem recently.

    But you say it is malformed header (or whatever) and doesn't seem like a timing issue.

    So what would cause it to be malformed (jquery and its libraries json, possibly other jqueries interfering) just rambling...

    incoming inform message and notification???

    are you still using the same version of php?

    i've not changed my php version since setting up my ubuntu servers over a year ago.

    unfortunately, since the issue does not happen "on-command" yet, it still is happening enough that my users are no longer participating on my site regularly, it puts me right back in the same spot. i need to move off of this platform before my forum is dead.

    as far as malformed header - i dont know. i was grasping at straws. my best guess at this point is a malformed JSON response from the first comment interaction. but why, i dont know.

  • peregrineperegrine MVP
    edited November 2013

    good luck! hope it gets resolved one way or other.

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • i'm sure that if someone had a deep DEEP understanding of the two post interactions and the whole mechanism for how the comments update in the data list, then they could isolate the problem pretty fast.

    Unfortunately this is beyond my understanding of the mechanics of the framework. and digging in that deep seems like i'll be going well beyond the level of "DIY" I feel comfortable with on this software. i dont want to manage my own fork.

  • I did some more digging.

    What do you have as your comment sort order?

    Have you nuked your cookies?

    You said you experienced this problem with and without the badges and awards plugins enabled?

    Search first

    Check out the Documentation! We are always looking for new content and pull requests.

    Click on insightful, awesome, and funny reactions to thank community volunteers for their valuable posts.

  • Double post!

    Were you able to get a record of the malformed requests?

    Search first

    Check out the Documentation! We are always looking for new content and pull requests.

    Click on insightful, awesome, and funny reactions to thank community volunteers for their valuable posts.

  • @hgtonight said:
    I did some more digging.

    What do you have as your comment sort order?

    Have you nuked your cookies?

    You said you experienced this problem with and without the badges and awards plugins enabled?

    default comment sort order
    nuking cookies seems to work sometimes for users experiencing the issue, but not always, I've not seen a pattern.

    I've experienced it on two completely separate installs, prod and test. The test environment has Diego's Awards plugin running on it right now, I had the issue whether that was enable or not.

  • @hgtonight said:
    Double post!

    Were you able to get a record of the malformed requests?

    i thought i posted a malformed and a proper request in this thread. I'll go back and check

  • You posted one of the malformed request headers, IIRC.

    Reading through the code, the only possible explanation I can see is the discussion/comment is getting unset, so a new comment form view gets rendered and inserted instead of the posted comment.

    When this happens, does the comment appear in the db? Meaning, if you refresh the page when it happens, does your comment show?

    Search first

    Check out the Documentation! We are always looking for new content and pull requests.

    Click on insightful, awesome, and funny reactions to thank community volunteers for their valuable posts.

  • peregrineperegrine MVP
    edited November 2013

    If it were me, I would go to your live site and post announcement for people to be patient and that you are trying to get to root of the problem.

    re-install vanilla 2.0.1.18.8 on live site since you say the problem exacerbates with vanilla 2.0.18.8. and disable any plugins that you may have installed in the past few months. And install stop autodraft.

    then we can look at the problem if it is less intermittent.

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • @hgtonight said:
    You posted one of the malformed request headers, IIRC.

    Reading through the code, the only possible explanation I can see is the discussion/comment is getting unset, so a new comment form view gets rendered and inserted instead of the posted comment.

    When this happens, does the comment appear in the db? Meaning, if you refresh the page when it happens, does your comment show?

    no, hitting refresh shows that the content was not committed to the DB.

  • so is the problem happening as we speak.

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

  • @peregrine said:
    If it were me, I would go to your live site and post announcement for people to be patient and that you are trying to get to root of the problem.

    re-install vanilla 2.0.1.18.8, since you say the problem exacerbates with vanilla 2.0.18.8

    then we can look at the problem if it is less intermittent.

    i'd rather set up a separate clone environment, upgrade to 18.8 and see if we get the issue there.

  • hbfhbf MVP
    edited November 2013

    its happening again.

    here'e the request header

    Request URL:http://homebrewforums.net/vanilla/post/comment/1
    Request Method:POST
    Status Code:200 OK
    Request Headersview source
    Accept:application/json, text/javascript, */*; q=0.01
    Accept-Encoding:gzip,deflate,sdch
    Accept-Language:en-US,en;q=0.8
    Connection:keep-alive
    Content-Length:289
    Content-Type:application/x-www-form-urlencoded
    Cookie:Vanilla=2-1386569344%7C7391a87311f976a095ae68c56c9d9565%7C1383977344%7C2%7C1386569344; VanillaSessionID=081f4e641d74bea921a53f6c445388e5; __utma=40087355.2022093394.1383927095.1384623492.1384667753.39; __utmc=40087355; __utmz=40087355.1384099393.6.2.utmcsr=homebrewforums.net|utmccn=(referral)|utmcmd=referral|utmcct=/discussion/1202/tap-issues; Vanilla-Volatile=2-1384841504%7Ce23b3eb23774dc8223cf39c49e5190e4%7C1384668704%7C2%7C1384841504
    Host:homebrewforums.net
    Origin:http://homebrewforums.net
    Referer:http://homebrewforums.net/discussion/1/tkt-no-holds-barred/p12452
    User-Agent:Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/30.0.1599.101 Safari/537.36
    X-Requested-With:XMLHttpRequest
    Form Dataview sourceview URL encoded
    Comment/TransientKey:S3YGLVANAKIO
    Comment/hpt:
    Comment/DiscussionID:1
    Comment/CommentID:
    Comment/DraftID:
    Comment/Body:test
    APC_UPLOAD_PROGRESS:1384667927412_UploadAttachment_9
    MAX_UPLOAD_SIZE:2097152
    DeliveryType:VIEW
    DeliveryMethod:JSON
    Type:Post
    Comment/LastCommentID:269284
    Response Headersview source
    Cache-Control:private, no-cache, no-store, must-revalidate
    Connection:Keep-Alive
    Content-Encoding:gzip
    Content-Length:1457
    Content-Type:text/html; charset=utf-8
    Date:Sun, 17 Nov 2013 06:49:16 GMT
    Expires:Sat, 01 Jan 2000 00:00:00 GMT
    Keep-Alive:timeout=5, max=100
    Pragma:no-cache
    Server:Apache/2.2.22 (Ubuntu)
    Vary:Accept-Encoding
    X-Garden-Version:Vanilla 2.0.18.8
    X-Powered-By:PHP/5.3.10-1ubuntu3.8
    
  • here's the response:

    {"FormSaved":true,"DeliveryType":"VIEW","Data":"PGRpdiBjbGFzcz0iTWVzc2FnZUZvcm0gQ29tbWVudEZvcm0iPgogICAgICA8ZGl2IGNsYXNzPSJUYWJzIENvbW1lbnRUYWJzIj4KICAgICAgPHVsPgogICAgICAgICA8bGkgY2xhc3M9IkFjdGl2ZSI+PGEgaHJlZj0iL3ZhbmlsbGEvcG9zdC9jb21tZW50LzEjIiBjbGFzcz0iV3JpdGVCdXR0b24gVGFiTGluayI+V3JpdGUgQ29tbWVudDwvYT48L2xpPgogICAgICAgICA8bGk+PGEgaHJlZj0iL3ZhbmlsbGEvcG9zdC9jb21tZW50LzEjIiBjbGFzcz0iUHJldmlld0J1dHRvbiBUYWJMaW5rIj5QcmV2aWV3PC9hPjwvbGk+CjxsaT48YSBocmVmPSIvdmFuaWxsYS9wb3N0L2NvbW1lbnQvMSMiIGNsYXNzPSJEcmFmdEJ1dHRvbiBUYWJMaW5rIj5TYXZlIERyYWZ0PC9hPjwvbGk+CiAgICAgIDwvdWw+CiAgIDwvZGl2PgogICA8Zm9ybSBpZD0iRm9ybV9Db21tZW50IiBtZXRob2Q9InBvc3QiIGFjdGlvbj0iL3ZhbmlsbGEvcG9zdC9jb21tZW50LzEiPgo8ZGl2Pgo8aW5wdXQgdHlwZT0iaGlkZGVuIiBpZD0iRm9ybV9UcmFuc2llbnRLZXkiIG5hbWU9IkNvbW1lbnQvVHJhbnNpZW50S2V5IiB2YWx1ZT0iNVcyV1MwQ0Q3MjVGIiAvPjxpbnB1dCB0eXBlPSJoaWRkZW4iIGlkPSJGb3JtX2hwdCIgbmFtZT0iQ29tbWVudC9ocHQiIHZhbHVlPSIiIHN0eWxlPSJkaXNwbGF5OiBub25lOyIgLz48aW5wdXQgdHlwZT0iaGlkZGVuIiBpZD0iRm9ybV9EaXNjdXNzaW9uSUQiIG5hbWU9IkNvbW1lbnQvRGlzY3Vzc2lvbklEIiB2YWx1ZT0iMSIgLz48aW5wdXQgdHlwZT0iaGlkZGVuIiBpZD0iRm9ybV9Db21tZW50SUQiIG5hbWU9IkNvbW1lbnQvQ29tbWVudElEIiB2YWx1ZT0iIiAvPjxpbnB1dCB0eXBlPSJoaWRkZW4iIGlkPSJGb3JtX0RyYWZ0SUQiIG5hbWU9IkNvbW1lbnQvRHJhZnRJRCIgdmFsdWU9IiIgLz48ZGl2IGNsYXNzPSJCdXR0b25CYXIiPgogICA8ZGl2PjxzcGFuPmJvbGQ8L3NwYW4+PC9kaXY+CiAgIDxkaXY+PHNwYW4+aXRhbGljPC9zcGFuPjwvZGl2PgogICA8ZGl2PjxzcGFuPnVuZGVybGluZTwvc3Bhbj48L2Rpdj4KICAgPGRpdj48c3Bhbj5zdHJpa2U8L3NwYW4+PC9kaXY+CiAgIDxkaXY+PHNwYW4+Y29kZTwvc3Bhbj48L2Rpdj4KICAgPGRpdj48c3Bhbj5pbWFnZTwvc3Bhbj48L2Rpdj4KICAgPGRpdj48c3Bhbj51cmw8L3NwYW4+PC9kaXY+CiAgIDxkaXY+PHNwYW4+cXVvdGU8L3NwYW4+PC9kaXY+CiAgIDxkaXY+PHNwYW4+c3BvaWxlcjwvc3Bhbj48L2Rpdj4KPC9kaXY+PGRpdiBjbGFzcz0iVGV4dEJveFdyYXBwZXIiPjx0ZXh0YXJlYSBpZD0iRm9ybV9Cb2R5IiBuYW1lPSJDb21tZW50L0JvZHkiIHJvd3M9IjYiIGNvbHM9IjEwMCIgY2xhc3M9IlRleHRCb3giPnRlc3Q8L3RleHRhcmVhPjwvZGl2PjxkaXYgY2xhc3M9IkJ1dHRvbnMiPgo8ZGl2IGNsYXNzPSJBdHRhY2hGaWxlV3JhcHBlciBBdHRhY2htZW50V2luZG93Ij4KICAgPGRpdiBjbGFzcz0iQXR0YWNoRmlsZUxpbmsiPgogICAgICA8YSBocmVmPSJqYXZhc2NyaXB0OnZvaWQoMCk7Ij5BdHRhY2ggYSBmaWxlPC9hPgogICAgICA8ZGl2IGNsYXNzPSJDdXJyZW50VXBsb2FkZXIiPjwvZGl2PgogICA8L2Rpdj4KICAgPGRpdiBjbGFzcz0iQXR0YWNoRmlsZUNvbnRhaW5lciI+CiAgICAgIDxkaXYgY2xhc3M9IlByb3RvdHlwaWNhbEF0dGFjaG1lbnQiIHN0eWxlPSJkaXNwbGF5Om5vbmU7Ij4KICAgICAgICAgPGRpdiBjbGFzcz0iQXR0YWNobWVudCI+CiAgICAgICAgICAgIDxkaXYgY2xhc3M9IkZpbGVQcmV2aWV3Ij48L2Rpdj4KICAgICAgICAgICAgPGRpdiBjbGFzcz0iRmlsZUhvdmVyIj4KICAgICAgICAgICAgICAgPGRpdiBjbGFzcz0iRmlsZU1ldGEiPgogICAgICAgICAgICAgICAgICA8ZGl2PgogICAgICAgICAgICAgICAgICAgICA8c3BhbiBjbGFzcz0iRmlsZU5hbWUiPkZpbGVOYW1lPC9zcGFuPgogICAgICAgICAgICAgICAgICAgICA8c3BhbiBjbGFzcz0iRmlsZVNpemUiPkZpbGVTaXplPC9zcGFuPgogICAgICAgICAgICAgICAgICA8L2Rpdj4KICAgICAgICAgICAgICAgICAgPHNwYW4gY2xhc3M9IkZpbGVPcHRpb25zIj48L3NwYW4+CiAgICAgICAgICAgICAgICAgIDxhIGNsYXNzPSJJbnNlcnRJbWFnZSBIaWRkZW4iPkluc2VydCBJbWFnZTwvYT4KICAgICAgICAgICAgICAgPC9kaXY+CiAgICAgICAgICAgIDwvZGl2PgogICAgICAgICA8L2Rpdj4KICAgICAgICAgPGRpdiBjbGFzcz0iVXBsb2FkUHJvZ3Jlc3MiPgogICAgICAgICAgICA8ZGl2IGNsYXNzPSJGb3JlZ3JvdW5kIj48c3Ryb25nPlVwbG9hZGluZy4uLjwvc3Ryb25nPjwvZGl2PgogICAgICAgICAgICA8ZGl2IGNsYXNzPSJCYWNrZ3JvdW5kIj4mbmJzcDs8L2Rpdj4KICAgICAgICAgICAgPGRpdj4mbmJzcDs8L2Rpdj4KICAgICAgICAgPC9kaXY+CiAgICAgIDwvZGl2PgogICA8L2Rpdj4KPC9kaXY+CjxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KICAgaWYgKEdkblVwbG9hZGVycykKICAgICAgR2RuVXBsb2FkZXJzLlByZXBhcmUoKTsKPC9zY3JpcHQ+PGEgaHJlZj0iL2Rpc2N1c3Npb25zIiBjbGFzcz0iQmFjayI+QmFjayB0byBEaXNjdXNzaW9uczwvYT48aW5wdXQgdHlwZT0ic3VibWl0IiBpZD0iRm9ybV9Qb3N0Q29tbWVudCIgbmFtZT0iQ29tbWVudC9Qb3N0X0NvbW1lbnQiIHZhbHVlPSJQb3N0IENvbW1lbnQiIGNsYXNzPSJCdXR0b24gQ29tbWVudEJ1dHRvbiIgLz4KPC9kaXY+CjwvZGl2Pgo8L2Zvcm0+PC9kaXY+","InformMessages":[],"ErrorMessages":"","RedirectUrl":""}

Sign In or Register to comment.