Howdy, Stranger!

It looks like you're new here. If you want to get involved, click one of these buttons!

Try Vanilla Forums Cloud product

Getting updated versions of addons in the .org directory

2»

Comments

  • peregrineperegrine MVP
    edited December 2014

    @Linc said

    @peregrine said: but I don't know what it will take for you to implement

    I provided a bullet point list.

    Increment the 3rd version number, don't add a fourth.

    done.

    Don't modify the plugin description.

    done. meaning not done

    Match our coding standard for bracing (always brace if statements) and indents.

    attempted to get within the marks and lord Bracko standards.

    I think you copy/pasted in the + signs from a git diff.

    yes I did.

    but this time I cut and pasted from my localhost.

    It would be better if it attempted to detect & use the CategoryModel::PermissionCategory method if it's available. That will future-proof the change so FileUpload isn't stuck on its own fork of that method forever.

    futureproofed.

    my ultimate best and final attempt.

    https://github.com/peregrine-web/addons/compare/vanilla:master...patch-1?quick_pull=1

    if that don't work. I will have to give up on github, since I can't clone on my computer, i have to pencil in changes on github itself.

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

    vrijvlinderhgtonight
  • vrijvlindervrijvlinder Papillon-Sauvage MVP

    And I appreciate it, which is why I want to help test it once someone can give me a perfect copy.
    I am only admitting to my lack of expertise in fulfilling what is being requested. Not criticizing it by any means.

    I only want to help fix the addons so people are happy.

    peregrine
  • peregrineperegrine MVP
    edited December 2014

    you can test after @linc merges the pull request if you like or you can look at the diff in previous comment.

    I may not provide the completed solution you might desire, but I do try to provide honest suggestions to help you solve your issue.

    hgtonight
  • LincLinc Vanilla's Bard (and Director of Development) Detroit Vanilla Staff

    @peregrine Looks good, I grabbed the commit and brought it over here: https://github.com/vanilla/addons/pull/169 so I can help if it has anything else crop up. Good work, thanks!

    peregrine
  • The authorselector plugin needs to be updated.

    https://open.vanillaforums.com/addon/authorselector-plugin

    • Have you verified the new version works with the current open source release(s)?

    Yes

    • Have you verified it doesn't introduce new issues?

    Yes

    • Are you satisfied it's a worthwhile upgrade?

    Yes, because the 2014 version breaks advanced editor.

    If two developers sign off on a plugin at a particular version, I'll download from GitHub and upload it to the directory. Please mention me after the second sign off.

    Anyone O:) ?

  • R_JR_J Cheerleader & Troubleshooter Munich Moderator

    @Caylus said:
    The authorselector plugin needs to be updated.

    https://open.vanillaforums.com/addon/authorselector-plugin

    If two developers sign off on a plugin at a particular version, I'll download from GitHub and upload it to the directory. Please mention me after the second sign off.

    Anyone O:) ?

    Which version (GitHub branch) have you tested?

2»
Sign In or Register to comment.