Getting updated versions of addons in the .org directory

Linc · November 2014

If there is an addon in the Addons repo that needs to be updated in the directory and you want me to upload the new version, this is what I need to know:

Have you verified the new version works with the current open source release(s)?
Have you verified it doesn't introduce new issues?
Are you satisfied it's a worthwhile upgrade?

If two developers sign off on a plugin at a particular version, I'll download from GitHub and upload it to the directory. Please mention me after the second sign off.

peregrine · November 2014

Pockets 1.1.2

Have you verified the new version works with the current open source release(s)?

Pockets 1.1.2 works for me in Vanilla 2.1.5 (I don't have vanilla 2.0.18.x and did not test).

Have you verified it doesn't introduce new issues?

Haven't noticed any.

Are you satisfied it's a worthwhile upgrade?

Yes.

peregrine · November 2014

what's curious to me is no one is seconding this? Has anyone found a problem with pockets 1.1.2

or is it apathy?

Linc · November 2014

To be fair, I don't think everyone checks in daily like we do. Also, it suddenly becomes a little more time consuming to do things like this when it's you're responsibility to not mess it up.

Bleistivt · November 2014

@Linc signing pockets. I haven't found issues too. It's probably the plugin that spawns the most "doesn't work"-threads, second to fileupload.

Unfortunately I can't sign fileupload, but maybe these changes could be merged into the 2.1 branch on github: http://vanillaforums.org/discussion/28532/a-mod-to-file-upload-version-1-8-4-to-make-it-work-with-vanilla-2-1-5

If @peregrine doesn't want to do it, I will make a pull request for these changes.

peregrine · November 2014

@Bleistivt said:

@Linc signing pockets. I haven't found issues too. It's probably the plugin that spawns the most "doesn't work"-threads, second to fileupload.

Unfortunately I can't sign fileupload, but maybe these changes could be merged into the 2.1 branch on github: http://vanillaforums.org/discussion/28532/a-mod-to-file-upload-version-1-8-4-to-make-it-work-with-vanilla-2-1-5

If @peregrine doesn't want to do it, I will make a pull request for these changes.

@Bleistivt, thank you for verifying pockets.

regarding file upload, be my guest and feel free to file any pull requests. I , just made it so it doesn't crash, as far as test the feature - Added the ability to restrict file uploads per category. I didn't check that aspect of it, and it may not work. But the plugin works for uploading and downloading via role as it did before.

my computer connection - does not like pull requests.

Q&A is another plugin that frequently needs user changes to make it work as well. I filed some issues, but no pull requests.

Bleistivt · November 2014

Would be cool if someone could verify if this is correct:

https://github.com/vanilla/addons/pull/154

Linc · November 2014

Pockets 1.1.2 it is: http://vanillaforums.org/addon/pockets-plugin-1.1.2

peregrine · November 2014

Quotes 1.6.9 with markdown (and buttonbar plugin) appears to work (the same as on this forum) with vanilla 2.1.5, if someone wants to test other formats.

And since it has a security fix in 1.6.9 - it might be worth the effort to test and update the add-ons section when tested.

Bleistivt · November 2014

As for QnA, @businessdad‌ has forked the addons repository and backported many plugins to work with 2.0.18, they might also work with 2.1:

https://github.com/daigo75/Addons/tree/Working_with_Vanilla_2.0.18.x/plugins/QnA

JasonBarnabe · November 2014

@peregrine said:
Quotes 1.6.9 with markdown (and buttonbar plugin) appears to work (the same as on this forum) with vanilla 2.1.5, if someone wants to test other formats.

And since it has a security fix in 1.6.9 - it might be worth the effort to test and update the add-ons section when tested.

I've found Quotes 1.6.8 (master before the XSS fix) on 2.1.5 works fine, with the exception of https://github.com/vanilla/addons/issues/152

hgtonight · November 2014

@Linc I am signing off on:

Akismet 1.0.3
Quotes 1.6.9
StopForumSpam 1.0.1

peregrine · November 2014

Linc · November 2014

Quotes 1.6.9 it up: http://vanillaforums.org/addon/quotes-plugin-1.6.9

peregrine · November 2014

I would think

https://github.com/vanilla/locales/blob/master/tx-source/dash_core.php

https://github.com/vanilla/locales/blob/master/tx-source/site_core.php

could be added to baseline and baseline updated.

http://vanillaforums.org/addon/baseline-locale

don't think it could break anything and would certainly be more up to date

with a slight revamp to file names.

Linc · November 2014

We should also make it clear that Baseline is not how to do language translation packs anymore, since we use Transifex for that. I could see it being used to build "styles" of languages or unofficial ones tho, so it still has utility.

Linc · November 2014

It looks like Akismet 1.0.3 and SFS 1.0.1 are awaiting seconds.

vrijvlinder · November 2014

@Linc can you technically update any addon ? Or should one simply fix them and change the names and then place the addon that did not work for 2.1 in the 2.0 addon archive ?

Some addons only need small stuff to work and it is a shame to leave them.

Linc · December 2014

I could, but I'm very reticent to do so. You'd need to contact the original author or fork the plugin as your own if the license allows. I have enough responsibility without taking on random plugins.

peregrine · December 2014

@Linc said:
I could, but I'm very reticent to do so. You'd need to contact the original author or fork the plugin as your own if the license allows. I have enough responsibility without taking on random plugins.

what about staff authors can you change plugins, by other staff members who don't seem to update their plugins in the add-ons section?

e.g.

Participated 1.1.0 from the Master addons.

be careful it is different then Participated 1.1.0 in the 2.1 github add-ons (no versioning update).

and still different from Participated 1.0.0 in the add-ons.

Participated 1.1.0 from master github addons - seems to work fine in Vanilla 2.1.6

it needs someone else to second, and jump through the hoop.

Linc · December 2014

Oh for sure, if it's Todd/Tim/me, it's usually pretty arbitrary who "owns" it anyway. I really wish there was a "staff" setting for official ones like that.

R_J · December 2014

Make it a @minion plugin

vrijvlinder · December 2014

Ok, @Linc in an effort to update the repo here, I am seconding peregrine that Participated plugin at the github vanilla addons master works with 2.1.6 so it can be updated here as well. Thanks.

peregrine · December 2014

@Bleistivt said:
Would be cool if someone could verify if this is correct:

https://github.com/vanilla/addons/pull/154

1.8.4.1 worked for me and other people and did no harm.

@linc

Linc · December 2014

@vrijvlinder Participated 1.1.0 is up.

@peregrine I responded to that PR now. It isn't ready.

peregrine · December 2014

@Linc said:
https://github.com/peregrine-web/addons/tree/patch-1

peregrine I responded to that PR now. It isn't ready.

your choice, if you want a File Upload plugin that works in vanilla 2.1 and then you can add it to add-ons.
explanation included.

https://github.com/peregrine-web/addons/tree/patch-1

https://github.com/peregrine-web/addons/compare/vanilla:master...peregrine-web:patch-1?expand=1

but the above will work from what I've heard back from other users.

bleistivt can explain any more changes or make further pull requests, or override.

Linc · December 2014

@peregrine That change looks a lot more reasonable, but there are some errors.

Increment the 3rd version number, don't add a fourth.
Don't modify the plugin description.
Match our coding standard for bracing (always brace if statements) and indents.
I think you copy/pasted in the + signs from a git diff.

It would be better if it attempted to detect & use the CategoryModel::PermissionCategory method if it's available. That will future-proof the change so FileUpload isn't stuck on its own fork of that method forever.

The PR I commented on earlier looked nothing like that simple patch you just linked.

Bleistivt · December 2014

Oops, looks like i forgot adding any kind of description.
The pull request was larger because the base was 2.1

But if we can get master to work for both versions, that'll be even better.

peregrine · December 2014

@Linc said:
peregrine That change looks a lot more reasonable, but there are some errors.

Increment the 3rd version number, don't add a fourth.

Don't modify the plugin description.

Match our coding standard for bracing (always brace if statements) and indents.

I think you copy/pasted in the + signs from a git diff.

It would be better if it attempted to detect & use the CategoryModel::PermissionCategory method if it's available. That will future-proof the change so FileUpload isn't stuck on its own fork of that method forever.

The PR I commented on earlier looked nothing like that simple patch you just linked.

ok. you know what you want, you see the issue. your decision. once again.

I understand your tips, thanks for the hints.

but I don't know what it will take for you to implement, it seems to be forever a catch-22.

add an is_method in and an if... to make it compatible,

I didn't add any if statements, that was your master version not following your own coding standards.

as seen here:

https://github.com/vanilla/addons/blob/master/plugins/FileUpload/class.fileupload.plugin.php#L62

so that would be a coding standard bug fix that you guys might want to change.

it is extemely hard to make reasonable github requests on addons section.

the master and 2.1 are so different.

and belistivt tried to act on 2.1 and tried to act on master.

after a while if it becomes too hard for a 4 line change, some of us are going to give up making suggestions to help the community have an easier time downloading a plugin. I know I am getting worn out.

vrijvlinder · December 2014

Ok , I suggest starting again here with fileupload, I am too new to php to know how to uphold the standards you have set. But in effort to get the ball rolling, Someone apt, please make the changes needed to satisfy the most stringent lord and give me a zip so I can second and third this plugin so we can move on to the next one ...

No? Let us test the spirit of working together to reach a goal fast !!! before I turn into the grinch that stole x-mas and New Year and whatever you throw at me...

Linc · December 2014

@peregrine said:
but I don't know what it will take for you to implement

I provided a bullet point list.

@peregrine said:
that was your master version not following your own coding standards.

That's correct, we update it as we change code.

@vrijvlinder said:
the changes needed to satisfy the most stringent lord

I spent my Friday night dealing with code emergencies, then woke up early on a Saturday to try and get thru my hopeless backlog of issues (and this ain't even one of them), and yet I'm sitting here patiently explaining coding standards to help you be a part of our process so things like this can happen faster, and I'm getting sass in return. It isn't appreciated.

Yes, I could fix it in 5 minutes. But I'd rather spend 15 teaching you how to be involved because I only have so many 5-minute increments in a day, and it turns out that doesn't scale the way you wish it would.

Howdy, Stranger!

Categories

In this Discussion

Getting updated versions of addons in the .org directory

Comments

Howdy, Stranger!

Quick Links

Categories

In this Discussion

Getting updated versions of addons in the .org directory

Comments